From d2f72641b214268a2e9dd0d64d0e923385d20a2b Mon Sep 17 00:00:00 2001
From: Morne Alberts <morne+claude@malberts.net>
Date: Thu, 8 Oct 2026 16:40:16 +0200
Subject: [PATCH] Tolerate lazy-loaded thumbnails in the image modal tests

MediaWiki master now defaults `$wgNativeImageLazyLoading` to true (false
through REL1_46, changed for T148047), so thumbnails carry `loading="lazy"`
and the image modal tests' thumbnail regexes fail on the MW master CI leg.
Make the attribute optional, as the patterns already do for `alt=""` and
` /`: `loading` is MediaWiki's markup, which this extension never emits,
so the tests accept either form rather than pin the setting.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---
 tests/phpunit/Unit/ImageModalTest.php        | 4 ++--
 tests/phpunit/Unit/ImageModalTriggerTest.php | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/phpunit/Unit/ImageModalTest.php b/tests/phpunit/Unit/ImageModalTest.php
index d1a1ce2..dd25b0f 100644
--- a/tests/phpunit/Unit/ImageModalTest.php
+++ b/tests/phpunit/Unit/ImageModalTest.php
@@ -346,7 +346,7 @@ public function canParseDataProvider(): array
 					'framed'      => false,
 				],
 				[],
-				'~<div class="thumb tnone"><span class="modal-trigger" data-bs-toggle="modal" data-bs-target="#bsc_modal_test"><div class="thumbinner" style="width:96px;"><span><img( alt="")? src="' . $scriptPath . '/images/a/aa/Shuttle.png" decoding="async" width="94" height="240" class="thumbimage"( /)?></span>  <div class="thumbcaption"></div></div></span></div>~',
+				'~<div class="thumb tnone"><span class="modal-trigger" data-bs-toggle="modal" data-bs-target="#bsc_modal_test"><div class="thumbinner" style="width:96px;"><span><img( alt="")? src="' . $scriptPath . '/images/a/aa/Shuttle.png" decoding="async"( loading="lazy")? width="94" height="240" class="thumbimage"( /)?></span>  <div class="thumbcaption"></div></div></span></div>~',
 				'<div class="modal fade" role="dialog" id="bsc_modal_test" aria-hidden="true"><div class="modal-dialog modal-lg"><div class="modal-content"><div class="modal-header"><button type="button" class="btn-close" data-bs-dismiss="modal" aria-label="Close"></button></div><div class="modal-body"><img src=TEST_OUTPUT class="img-fluid"></div>'
 				. '<div class="modal-footer"><a class="btn btn-primary" role="button" href="/File:Serenity.png">Visit Source</a><button type="button" class="btn btn-default" data-bs-dismiss="modal" aria-label="Close">Close</button></div></div></div></div>' . "\n",
 			],
@@ -378,7 +378,7 @@ public function canParseDataProvider(): array
 					'manualthumb' => 'Shuttle.png',
 				],
 				[],
-				'~<div class="thumb tleft"><span class="modal-trigger" data-bs-toggle="modal" data-bs-target="#bsc_modal_test"><div class="thumbinner" style="width:96px;"><span><img( alt="")? src="' . $scriptPath . '/images/a/aa/Shuttle.png" decoding="async" width="94" height="240" class="thumbimage"( /)?></span>  <div class="thumbcaption"><div class="magnify"><a class="internal" title="Enlarge"></a></div></div></div></span></div>~',
+				'~<div class="thumb tleft"><span class="modal-trigger" data-bs-toggle="modal" data-bs-target="#bsc_modal_test"><div class="thumbinner" style="width:96px;"><span><img( alt="")? src="' . $scriptPath . '/images/a/aa/Shuttle.png" decoding="async"( loading="lazy")? width="94" height="240" class="thumbimage"( /)?></span>  <div class="thumbcaption"><div class="magnify"><a class="internal" title="Enlarge"></a></div></div></div></span></div>~',
 				'<div class="modal fade" role="dialog" id="bsc_modal_test" aria-hidden="true"><div class="modal-dialog modal-lg"><div class="modal-content"><div class="modal-header"><button type="button" class="btn-close" data-bs-dismiss="modal" aria-label="Close"></button></div>'
 				. '<div class="modal-body"><img src=TEST_OUTPUT class="img-fluid"></div><div class="modal-footer"><a class="btn btn-primary" role="button" href="/File:Serenity.png">Visit Source</a><button type="button" class="btn btn-default" data-bs-dismiss="modal" aria-label="Close">Close</button></div></div></div></div>' . "\n",
 			],
diff --git a/tests/phpunit/Unit/ImageModalTriggerTest.php b/tests/phpunit/Unit/ImageModalTriggerTest.php
index 19121c8..2bb3b73 100644
--- a/tests/phpunit/Unit/ImageModalTriggerTest.php
+++ b/tests/phpunit/Unit/ImageModalTriggerTest.php
@@ -254,7 +254,7 @@ public function canParseProvider() {
 				[
 					'~<div class="thumb tnone"><span class="modal-trigger" data-bs-toggle="modal" data-bs-target="#id">~',
 					'~<div class="thumbinner" style="width:96px;">~',
-					'~<img( alt="")? src="' . $scriptPath . '/images/a/aa/Shuttle.png" decoding="async" width="94" height="240" class="thumbimage"( /)?>~',
+					'~<img( alt="")? src="' . $scriptPath . '/images/a/aa/Shuttle.png" decoding="async"( loading="lazy")? width="94" height="240" class="thumbimage"( /)?>~',
 				]
 			],
 			'framed'                         => [
@@ -319,7 +319,7 @@ public function canParseProvider() {
 				],
 				[
 					'~<div class="thumb tleft"><span class="modal-trigger" data-bs-toggle="modal" data-bs-target="#id"><div class="thumbinner" style="width:96px;">~',
-					'~<img( alt="")? src="' . $scriptPath . '/images/a/aa/Shuttle.png" decoding="async" width="94" height="240" class="thumbimage"( /)?>~',
+					'~<img( alt="")? src="' . $scriptPath . '/images/a/aa/Shuttle.png" decoding="async"( loading="lazy")? width="94" height="240" class="thumbimage"( /)?>~',
 					'~<div class="thumbcaption"><div class="magnify"><a class="internal" title="Enlarge">~',
 				]
 			],