From 004a8b47b83953c785020fe3d027190521444c24 Mon Sep 17 00:00:00 2001 From: dobbydobap Date: Fri, 11 Sep 2026 01:12:44 +0530 Subject: [PATCH] test: assert reported names in Wasm link errors The reserved-import-name LinkError started reporting the import name instead of the import module in 9766a672a7f, which landed without a test. These assertions only matched the literal message prefix, so they passed either way. Assert the interpolated name, so the two import-name cases fail against the old message, and tighten the export and import-module assertions in the same family, which had the same gap and could not tell each other's error apart. Refs: https://github.com/nodejs/node/pull/64950 Signed-off-by: dobbydobap --- test/es-module/test-esm-wasm-reject-wasm-export-names.mjs | 2 +- test/es-module/test-esm-wasm-reject-wasm-import-names.mjs | 2 +- test/es-module/test-esm-wasm-reject-wasm-js-export-names.mjs | 2 +- test/es-module/test-esm-wasm-reject-wasm-js-import-module.mjs | 2 +- test/es-module/test-esm-wasm-reject-wasm-js-import-names.mjs | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/test/es-module/test-esm-wasm-reject-wasm-export-names.mjs b/test/es-module/test-esm-wasm-reject-wasm-export-names.mjs index bf64ad0172ac..70f422c32b59 100644 --- a/test/es-module/test-esm-wasm-reject-wasm-export-names.mjs +++ b/test/es-module/test-esm-wasm-reject-wasm-export-names.mjs @@ -6,5 +6,5 @@ import * as fixtures from '../common/fixtures.mjs'; spawnSyncAndAssert( process.execPath, ['--no-warnings', fixtures.path('es-modules/test-wasm-reject-wasm-export-names.mjs')], - { status: 1, stderr: /Invalid Wasm export/ } + { status: 1, stderr: /Invalid Wasm export name "wasm:invalid"/ } ); diff --git a/test/es-module/test-esm-wasm-reject-wasm-import-names.mjs b/test/es-module/test-esm-wasm-reject-wasm-import-names.mjs index 6f37de1d8df5..ac36a76a38ac 100644 --- a/test/es-module/test-esm-wasm-reject-wasm-import-names.mjs +++ b/test/es-module/test-esm-wasm-reject-wasm-import-names.mjs @@ -6,5 +6,5 @@ import * as fixtures from '../common/fixtures.mjs'; spawnSyncAndAssert( process.execPath, ['--no-warnings', fixtures.path('es-modules/test-wasm-reject-wasm-import-names.mjs')], - { status: 1, stderr: /Invalid Wasm import name/ } + { status: 1, stderr: /Invalid Wasm import name "wasm:invalid"/ } ); diff --git a/test/es-module/test-esm-wasm-reject-wasm-js-export-names.mjs b/test/es-module/test-esm-wasm-reject-wasm-js-export-names.mjs index 3c080cd672fb..e7ce3c0cb9ed 100644 --- a/test/es-module/test-esm-wasm-reject-wasm-js-export-names.mjs +++ b/test/es-module/test-esm-wasm-reject-wasm-js-export-names.mjs @@ -6,5 +6,5 @@ import * as fixtures from '../common/fixtures.mjs'; spawnSyncAndAssert( process.execPath, ['--no-warnings', fixtures.path('es-modules/test-wasm-reject-wasm-js-export-names.mjs')], - { status: 1, stderr: /Invalid Wasm export/ } + { status: 1, stderr: /Invalid Wasm export name "wasm-js:invalid"/ } ); diff --git a/test/es-module/test-esm-wasm-reject-wasm-js-import-module.mjs b/test/es-module/test-esm-wasm-reject-wasm-js-import-module.mjs index 24bfe1fa5258..1dd293d25a2d 100644 --- a/test/es-module/test-esm-wasm-reject-wasm-js-import-module.mjs +++ b/test/es-module/test-esm-wasm-reject-wasm-js-import-module.mjs @@ -6,5 +6,5 @@ import * as fixtures from '../common/fixtures.mjs'; spawnSyncAndAssert( process.execPath, ['--no-warnings', fixtures.path('es-modules/test-wasm-reject-wasm-js-import-module.mjs')], - { status: 1, stderr: /Invalid Wasm import/ } + { status: 1, stderr: /Invalid Wasm import "wasm-js:invalid"/ } ); diff --git a/test/es-module/test-esm-wasm-reject-wasm-js-import-names.mjs b/test/es-module/test-esm-wasm-reject-wasm-js-import-names.mjs index 260ffaa7486f..11349676d2b3 100644 --- a/test/es-module/test-esm-wasm-reject-wasm-js-import-names.mjs +++ b/test/es-module/test-esm-wasm-reject-wasm-js-import-names.mjs @@ -6,5 +6,5 @@ import * as fixtures from '../common/fixtures.mjs'; spawnSyncAndAssert( process.execPath, ['--no-warnings', fixtures.path('es-modules/test-wasm-reject-wasm-js-import-names.mjs')], - { status: 1, stderr: /Invalid Wasm import name/ } + { status: 1, stderr: /Invalid Wasm import name "wasm-js:invalid"/ } );