From d6c2ba0169c7c2dd626820f5c0b6b24d900a6cec Mon Sep 17 00:00:00 2001 From: nextcloud-command Date: Sun, 6 Sep 2026 17:10:40 +0000 Subject: [PATCH] refactor: Apply rector changes Signed-off-by: GitHub --- lib/Service/CirclesService.php | 4 +--- lib/Service/SubmissionService.php | 5 +---- tests/Integration/IntegrationBase.php | 4 +--- 3 files changed, 3 insertions(+), 10 deletions(-) diff --git a/lib/Service/CirclesService.php b/lib/Service/CirclesService.php index c9156d143..deb85616f 100644 --- a/lib/Service/CirclesService.php +++ b/lib/Service/CirclesService.php @@ -70,9 +70,7 @@ public function isUserInCircle(string $circleId, string $userId): bool { $member = $circle->getInitiator(); $isUserInCircle = $member !== null && $member->getLevel() >= Member::LEVEL_MEMBER; - if (!isset($this->userCircleCache[$circleId])) { - $this->userCircleCache[$circleId] = []; - } + $this->userCircleCache[$circleId] ??= []; $this->userCircleCache[$circleId][$userId] = $isUserInCircle; return $isUserInCircle; diff --git a/lib/Service/SubmissionService.php b/lib/Service/SubmissionService.php index e8c036499..340022111 100644 --- a/lib/Service/SubmissionService.php +++ b/lib/Service/SubmissionService.php @@ -501,10 +501,7 @@ private function exportData(array $header, array $data, string $fileFormat, ?Fil $submissionId = (string)$rowData[$submissionIdColIndex]; $row = $existingSubmissionIds[$submissionId] ?? null; - if ($row === null) { - // Append new row - $row = $activeWorksheet->getHighestRow() + 1; - } + $row ??= $activeWorksheet->getHighestRow() + 1; $dataIndex = 0; $columnIndex = 1; diff --git a/tests/Integration/IntegrationBase.php b/tests/Integration/IntegrationBase.php index f7fcb2f80..7967679c0 100644 --- a/tests/Integration/IntegrationBase.php +++ b/tests/Integration/IntegrationBase.php @@ -43,9 +43,7 @@ public function setUp(): void { $userManager = \OCP\Server::get(IUserManager::class); foreach ($this->users as $userId => $displayName) { $user = $userManager->get($userId); - if ($user === null) { - $user = $userManager->createUser($userId, $userId); - } + $user ??= $userManager->createUser($userId, $userId); $user->setDisplayName($displayName); }