From 42d95164c4ee4769f8ec516055ee958295f4b934 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ianar=C3=A9=20S=C3=A9vi?= Date: Mon, 7 Sep 2026 18:24:57 +0200 Subject: [PATCH 1/2] :memo: better docs for model search --- mindee/v2/search/models/model_search_parameters.py | 13 ++++++++++--- tests/v2/search/test_model_search_integration.py | 4 ++++ 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/mindee/v2/search/models/model_search_parameters.py b/mindee/v2/search/models/model_search_parameters.py index e5f02ad6..cd5fdded 100644 --- a/mindee/v2/search/models/model_search_parameters.py +++ b/mindee/v2/search/models/model_search_parameters.py @@ -7,13 +7,20 @@ @dataclass(kw_only=True) class ModelSearchParameters(BaseSearchParameters[ModelSearchResponse]): - """Search parameters for models.""" + """ + Search for models within the organization linked to the API key. + + All search filters are optional. + If no search filters are given, all models belonging to the organization are returned. + + Results are paginated. + """ name: str | None = None - """Case-insensitive search term for the model name.""" + """Filter models by partial name match, case-insensitive.""" model_type: str | None = None - """Case-insensitive search term for the model type.""" + """Filter by an exact model type.""" _slug: ClassVar[str] = "models" _response_class: type[ModelSearchResponse] = ModelSearchResponse diff --git a/tests/v2/search/test_model_search_integration.py b/tests/v2/search/test_model_search_integration.py index 4c2a7e4b..409c1e53 100644 --- a/tests/v2/search/test_model_search_integration.py +++ b/tests/v2/search/test_model_search_integration.py @@ -16,6 +16,10 @@ def test_must_have_results(v2_client: Client): assert response is not None assert len(response.models) > 0 + for model in response.models: + assert model.id is not None + assert model.name is not None + assert model.model_type is not None assert response.pagination is not None assert response.pagination.total_items >= 1 assert response.pagination.page == 1 From d4c95c1eca9fa489487e824d9dbae7f44010724f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?ianar=C3=A9?= <97107275+ianardee@users.noreply.github.com> Date: Mon, 7 Sep 2026 18:43:44 +0200 Subject: [PATCH 2/2] Simplify model attribute assertions Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- tests/v2/search/test_model_search_integration.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/v2/search/test_model_search_integration.py b/tests/v2/search/test_model_search_integration.py index 409c1e53..53b4dc31 100644 --- a/tests/v2/search/test_model_search_integration.py +++ b/tests/v2/search/test_model_search_integration.py @@ -17,9 +17,9 @@ def test_must_have_results(v2_client: Client): assert response is not None assert len(response.models) > 0 for model in response.models: - assert model.id is not None - assert model.name is not None - assert model.model_type is not None + assert model.id + assert model.name + assert model.model_type assert response.pagination is not None assert response.pagination.total_items >= 1 assert response.pagination.page == 1