diff --git a/src/webview/page-antipatterns-editor-wiring.test.ts b/src/webview/page-antipatterns-editor-wiring.test.ts index 7623f218..15a52e25 100644 --- a/src/webview/page-antipatterns-editor-wiring.test.ts +++ b/src/webview/page-antipatterns-editor-wiring.test.ts @@ -454,3 +454,52 @@ describe('Anti-Patterns page rendered again by a save', () => { expect(calls('saveRule')).toHaveLength(2); }); }); + +describe('What the page shows after a save', () => { + it.each([1, 3])('one section per practice group after %i saves', async saves => { + const page = await renderPage(); + showDetail(page, A); + for (let save = 0; save < saves; save++) await saveShownRule(page, A); + expect([...page.querySelectorAll('#apDetails .ap-group-name')].map(name => name.textContent)) + .toEqual(['Prompt Quality', 'Session Hygiene', 'Code Review', 'Tool Mastery']); + }); + + it('the saved rule, in the detail that was open', async () => { + const page = await renderPage(); + showDetail(page, A); + await saveShownRule(page, A, [{ ...listed(A), description: 'The saved description.' }, listed(B)]); + expect(el(page, '#rule-detail-panel').style.display).toBe(''); + expect(el(page, '.rule-detail-desc').textContent).toBe('The saved description.'); + }); + + it('the rule list, when the rule whose detail was open is gone', async () => { + const page = await renderPage(); + showDetail(page, A); + await saveShownRule(page, A, [listed(B)]); + expect(el(page, '#rule-detail-panel').style.display).toBe('none'); + expect(el(page, '#rule-list').style.display).toBe(''); + }); + + it('the rule list, when the detail was closed with Back before a save', async () => { + const page = await renderPage(); + showDetail(page, A); + click(page, '#rule-back-btn'); + click(page, '#rule-new-btn'); + click(page, '.rule-editor-tab[data-editor-tab="source"]'); + el(page, '#rule-editor-raw').value = SOURCES[C]; + click(page, '#rule-editor-save'); + await answer('saveRule', { ok: true }); + expect(el(page, '#rule-detail-panel').style.display).toBe('none'); + expect(el(page, '#rule-list').style.display).toBe(''); + }); +}); + +async function saveShownRule(page: HTMLElement, id: string, rules?: Record[]): Promise { + await editShownRule(page, id); + const listing = mocks.rpc.getMockImplementation()!; + if (rules) mocks.rpc.mockImplementation((method: string, params?: Record) => method === 'getRuleEditor' + ? Promise.resolve({ ...PAGE_DATA.getRuleEditor as object, rules }) + : listing(method, params) as Promise); + click(page, '#rule-editor-save'); + await answer('saveRule', { ok: true }); +} diff --git a/src/webview/page-antipatterns.ts b/src/webview/page-antipatterns.ts index a3c9b413..095bfe0a 100644 --- a/src/webview/page-antipatterns.ts +++ b/src/webview/page-antipatterns.ts @@ -579,6 +579,9 @@ export async function renderAntiPatterns(container: HTMLElement, currentFilter: // Wire up rules section wireRulesSection(container, rules, previewMap, currentFilter); + + const openRuleId = container.querySelector('#rule-detail-panel')!.dataset.ruleId; + if (openRuleId) showRuleDetail(container, openRuleId, rules, previewMap, currentFilter); } /* ── Tab switching ── */ @@ -610,6 +613,7 @@ function renderFindings( ): void { const detailsContainer = container.querySelector('#apDetails')!; const allGroupKeys: PracticeGroup[] = ['prompt-quality', 'session-hygiene', 'code-review', 'tool-mastery']; + const sections: HTMLElement[] = []; for (const groupKey of allGroupKeys) { const gs = scores.find(s => s.group === groupKey); @@ -674,8 +678,9 @@ function renderFindings( section.appendChild(card); } } - detailsContainer.appendChild(section); + sections.push(section); } + detailsContainer.replaceChildren(...sections); const hint = consumeNavHint(); if (hint) { @@ -1037,12 +1042,7 @@ function wireRulesSection( }, { signal }); // Back button - container.querySelector('#rule-back-btn')?.addEventListener('click', () => { - container.querySelector('#rule-list')!.style.display = ''; - container.querySelector('#rule-detail-panel')!.style.display = 'none'; - container.querySelector('#rule-search-bar')!.style.display = ''; - container.querySelector('#ap-rules-header')!.style.display = ''; - }, { signal }); + container.querySelector('#rule-back-btn')?.addEventListener('click', () => hideRuleDetail(container), { signal }); // Unified Rule Editor wireRuleEditorModal(container, currentFilter, () => renderAntiPatterns(container, currentFilter), signal); @@ -1213,7 +1213,10 @@ function showRuleDetail( currentFilter: DateFilter, ): void { const rule = rules.find(r => r.id === ruleId); - if (!rule) return; + if (!rule) { + hideRuleDetail(container); + return; + } const preview = previewMap.get(ruleId); container.querySelector('#rule-list')!.style.display = 'none'; @@ -1222,6 +1225,7 @@ function showRuleDetail( const panel = container.querySelector('#rule-detail-panel')!; panel.style.display = ''; + panel.dataset.ruleId = ruleId; const content = container.querySelector('#rule-detail-content')!; render(renderRuleDetailContent(rule, preview, ruleId), content); @@ -1237,6 +1241,15 @@ function showRuleDetail( wireRuleDetailExplainButtons(content, currentFilter); } +function hideRuleDetail(container: HTMLElement): void { + const panel = container.querySelector('#rule-detail-panel')!; + panel.style.display = 'none'; + delete panel.dataset.ruleId; + container.querySelector('#rule-list')!.style.display = ''; + container.querySelector('#rule-search-bar')!.style.display = ''; + container.querySelector('#ap-rules-header')!.style.display = ''; +} + function renderLayerStatus(layers: RuleLayerInfo[], layerName: string): ComponentChildren { const info = layers.find(l => l.layer === layerName); if (!info) return html`Not applicable`;