From 936afbc656317eb41442b9c87bcdefd1bbe3607c Mon Sep 17 00:00:00 2001 From: Kevin Yakar Date: Thu, 29 Oct 2026 11:40:18 -0700 Subject: [PATCH] Only require gcc12 on EL9 to unblock BGP GitHub CI Summary: X-link: https://github.com/meta/BGP/pull/15 The BGP GitHub Actions workflow has failed on every run since it was added in July. It runs getdeps directly on an Ubuntu 24.04 runner, where `gcc12` cannot be resolved: `bgp` and `fboss` depend on it on every distro, but it only exists as an EL9 package, so getdeps aborts before building anything. Requiring `gcc12` only on EL9 matches `openr` and leaves the EL9 builds (internal BGP OSS CI and the FBOSS Docker image) unchanged. On Ubuntu the build uses the runner's default compiler. The workflow now also installs system packages first, since `openssl` can only come from the system and would otherwise be the next blocker. Differential Revision: D128386555 --- build/fbcode_builder/manifests/bgp | 2 ++ build/fbcode_builder/manifests/fboss | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/build/fbcode_builder/manifests/bgp b/build/fbcode_builder/manifests/bgp index 745c5091c8888..f999ceae6d8e4 100644 --- a/build/fbcode_builder/manifests/bgp +++ b/build/fbcode_builder/manifests/bgp @@ -31,6 +31,8 @@ openr = !default, !full, exported_libraries wangle re2 zstd + +[dependencies.all(distro_family=rhel,distro_vers=9)] gcc12 [cmake.defines.test=on] diff --git a/build/fbcode_builder/manifests/fboss b/build/fbcode_builder/manifests/fboss index b9f7d14f7a234..d47740728800e 100644 --- a/build/fbcode_builder/manifests/fboss +++ b/build/fbcode_builder/manifests/fboss @@ -61,9 +61,11 @@ libgpiod systemd range-v3 tabulate -gcc12 python-pyyaml +[dependencies.all(distro_family=rhel,distro_vers=9)] +gcc12 + # Shared FBOSS libraries and tests must not each register a static glog copy. [dependencies.os=linux] glog = shared_libs