Skip to content
This repository was archived by the owner on Feb 6, 2020. It is now read-only.
This repository was archived by the owner on Feb 6, 2020. It is now read-only.

Possible issues #1

Description

@mmalecki

According to our conversation on Twitter, these are possible issues (don't take all of them seriously, I'm a pedantic guy):

  • I'm not really sure about whole this layout. How about having things like this:
    • session.c and session.h with functions it has now + definition of http_session_s (in header - now it's inaccessible for external code),
    • message.c and message.h with http_message_s, http_error_codes and functions like http_message_set_header, http_request and http_response (and optionally parse-related function - I'm not sure if they fit right into session.c),
    • no http.h or http.h which would only include session.h and message.h,
    • possibly another pair of files (like stream.{h,c}) with those stream handling routines.
  • we should think about caching those sessions and keeping them alive.

This is how I would do it, but it's your project and everything is up to you. Of course I will be very glad to help.
Also, please ping me here or on Twitter if I'm being unclear or something (I've temporarily monkey-patched my sleep routine to call drink_coffee routine instead ;) ).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions