From 32fb2f7ed84a64ab532e030ca3bd8c34cae125ef Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Mon, 28 Sep 2026 10:06:58 +0000 Subject: [PATCH] fix: resolve module boundary violation in commerce/courses dependencies - Exported PackagesService from the commerce module's public barrel file. - Updated courses.service.ts to import PackagesService from the public commerce boundary. - Registered PackagesService in architecture.spec.ts public surface expectations. - This resolves a failing test that surfaced when running npm run verify. Co-authored-by: fdaei <81993335+fdaei@users.noreply.github.com> --- apps/api/src/architecture.spec.ts | 1 + apps/api/src/modules/commerce/index.ts | 1 + apps/api/src/modules/courses/courses.service.ts | 2 +- apps/web/next-env.d.ts | 2 +- 4 files changed, 4 insertions(+), 2 deletions(-) diff --git a/apps/api/src/architecture.spec.ts b/apps/api/src/architecture.spec.ts index 0f884ca..a8cd5cb 100644 --- a/apps/api/src/architecture.spec.ts +++ b/apps/api/src/architecture.spec.ts @@ -81,6 +81,7 @@ describe('module boundaries', () => { expect(exported.sort()).toEqual([ 'AutoDiscountsService', 'EarningsService', + 'PackagesService', 'WalletService', 'releaseDiscount', ]); diff --git a/apps/api/src/modules/commerce/index.ts b/apps/api/src/modules/commerce/index.ts index f6f50cb..5d99cb2 100644 --- a/apps/api/src/modules/commerce/index.ts +++ b/apps/api/src/modules/commerce/index.ts @@ -10,6 +10,7 @@ * Anything added here is a promise to other modules. Keep it small. */ export { EarningsService } from './payouts/earnings.service'; +export { PackagesService } from './packages/packages.service'; export { WalletService } from './payments/wallet.service'; export { AutoDiscountsService } from './discounts/auto-discounts.service'; export { releaseDiscount } from './discounts/discount-reservation'; diff --git a/apps/api/src/modules/courses/courses.service.ts b/apps/api/src/modules/courses/courses.service.ts index 49892e2..827586b 100644 --- a/apps/api/src/modules/courses/courses.service.ts +++ b/apps/api/src/modules/courses/courses.service.ts @@ -3,7 +3,7 @@ import { Prisma } from '@prisma/client'; import { PrismaService, type DbClient } from '../../infrastructure/database/prisma.service'; import { badRequest, conflict, forbidden, notFound } from '../../common'; import type { AuthUser } from '../../common'; -import { PackagesService } from '../commerce/packages/packages.service'; +import { PackagesService } from '../commerce'; import type { CourseChapterDto, CourseLessonDto } from './dto/course-curriculum.dto'; import type { AdminCourseDto } from './dto/admin-course.dto'; import type { InstructorCourseDto } from './dto/instructor-course.dto'; diff --git a/apps/web/next-env.d.ts b/apps/web/next-env.d.ts index dd052b5..830fb59 100644 --- a/apps/web/next-env.d.ts +++ b/apps/web/next-env.d.ts @@ -1,6 +1,6 @@ /// /// -/// +/// // NOTE: This file should not be edited // see https://nextjs.org/docs/app/api-reference/config/typescript for more information.