From 3a70b5e89dc1378908497374992bef4fe4ffea2e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fran=C3=A7ois=20Chalifour?= Date: Mon, 9 Nov 2026 14:56:00 +0100 Subject: [PATCH] fix(httpx): resolve request paths against the base URL --- lib/altertable/adapters.rb | 2 +- spec/altertable/adapters/delivery_spec.rb | 44 +++++++++++++++++++++++ 2 files changed, 45 insertions(+), 1 deletion(-) create mode 100644 spec/altertable/adapters/delivery_spec.rb diff --git a/lib/altertable/adapters.rb b/lib/altertable/adapters.rb index 4ea6fff..676e642 100644 --- a/lib/altertable/adapters.rb +++ b/lib/altertable/adapters.rb @@ -60,7 +60,7 @@ def initialize(base_url:, timeout:, headers: {}, proxy: nil) @client = client.with( timeout: { operation_timeout: @timeout }, headers: @headers, - base_url: @base_url + origin: @base_url ) end diff --git a/spec/altertable/adapters/delivery_spec.rb b/spec/altertable/adapters/delivery_spec.rb new file mode 100644 index 0000000..e8c3aef --- /dev/null +++ b/spec/altertable/adapters/delivery_spec.rb @@ -0,0 +1,44 @@ +# frozen_string_literal: true + +require "spec_helper" +require "socket" +require "timeout" + +RSpec.describe "Adapter delivery" do + # Accepts one request on a loopback socket and records its request line. + def with_http_sink + server = TCPServer.new("127.0.0.1", 0) + worker = Thread.new do + socket = Timeout.timeout(10) { server.accept } + begin + request_line = socket.gets + headers = {} + while (line = socket.gets) && line != "\r\n" + key, value = line.split(":", 2) + headers[key.downcase] = value.strip + end + socket.read(Integer(headers.fetch("content-length", "0"))) + body = '{"ok":true}' + socket.write("HTTP/1.1 200 OK\r\nContent-Type: application/json\r\nContent-Length: #{body.bytesize}\r\nConnection: close\r\n\r\n#{body}") + request_line + ensure + socket.close + end + end + yield "http://127.0.0.1:#{server.addr[1]}" + worker.value + ensure + worker&.kill + server&.close + end + + [:faraday, :httpx, :net_http].each do |adapter| + it "posts track events to the base URL over #{adapter}" do + request_line = with_http_sink do |base_url| + client = Altertable::Client.new("test-key", adapter: adapter, base_url: base_url, proxy: false) + expect(client.track("Signed Up", "user")).to eq("ok" => true) + end + expect(request_line).to start_with("POST /track") + end + end +end