From 5c93bbab2362309460f2defe50e2e6d6bbf1f4a6 Mon Sep 17 00:00:00 2001 From: marekl11 Date: Wed, 14 Oct 2026 18:05:26 +0200 Subject: [PATCH 1/2] fix: drop dead template attributes and finish eslint globals Remove the ignored value on four v-else directives, an invalid xmlns on a template tag and a missing space between attributes in EventPage, key the host list in EventDetails, and declare ResizeObserver and global in the eslint config. Templates compile to the same render code. --- eslint.config.js | 2 ++ resources/js/components/AlertBanner.vue | 2 +- resources/js/components/DeviceCategorySelect.vue | 2 +- resources/js/components/DeviceModel.vue | 2 +- resources/js/components/DeviceNotes.vue | 2 +- resources/js/components/DeviceProblem.vue | 2 +- resources/js/components/EventDetails.vue | 2 +- resources/js/components/EventPage.vue | 2 +- 8 files changed, 9 insertions(+), 7 deletions(-) diff --git a/eslint.config.js b/eslint.config.js index 74d2684520..3ee59d37a4 100644 --- a/eslint.config.js +++ b/eslint.config.js @@ -27,6 +27,7 @@ const browserGlobals = { URLSearchParams: 'readonly', XMLHttpRequest: 'readonly', MutationObserver: 'readonly', + ResizeObserver: 'readonly', getComputedStyle: 'readonly', alert: 'readonly', confirm: 'readonly', @@ -95,6 +96,7 @@ export default [ beforeAll: 'readonly', afterAll: 'readonly', jest: 'readonly', + global: 'readonly', require: 'readonly', module: 'readonly', }, diff --git a/resources/js/components/AlertBanner.vue b/resources/js/components/AlertBanner.vue index 16096db683..433336bf90 100644 --- a/resources/js/components/AlertBanner.vue +++ b/resources/js/components/AlertBanner.vue @@ -1,4 +1,4 @@ - diff --git a/resources/js/components/DeviceProblem.vue b/resources/js/components/DeviceProblem.vue index f0cdb9227b..6ab88c7d32 100644 --- a/resources/js/components/DeviceProblem.vue +++ b/resources/js/components/DeviceProblem.vue @@ -3,7 +3,7 @@
- +
diff --git a/resources/js/components/EventDetails.vue b/resources/js/components/EventDetails.vue index 8007fda403..37ad3f2307 100644 --- a/resources/js/components/EventDetails.vue +++ b/resources/js/components/EventDetails.vue @@ -43,7 +43,7 @@
-
+
{{ host.volunteer.name }}
diff --git a/resources/js/components/EventPage.vue b/resources/js/components/EventPage.vue index bbbc636994..1d7772f0c5 100644 --- a/resources/js/components/EventPage.vue +++ b/resources/js/components/EventPage.vue @@ -15,7 +15,7 @@
- +
From aead0b3643606140176f09f6b23fdd3b028a1d2c Mon Sep 17 00:00:00 2001 From: marekl11 Date: Wed, 14 Oct 2026 18:05:26 +0200 Subject: [PATCH 2/2] fix: drop dead template bindings and duplicate attributes Remove v-bind spreads on scoped-slot templates and an empty @select handler, which the compiler drops anyway, and the first of two allow-empty attributes (the second one already won). Listen for update:ready on GroupMap instead of the Vue 3 v-model:ready syntax. AlertBanner had both :variant and a static variant="secondary", so every alert rendered grey. Fall back to secondary only when there is no variant. --- resources/js/components/AlertBanner.vue | 3 +-- resources/js/components/DeviceCategorySelect.vue | 1 - resources/js/components/GroupEventScrollTable.vue | 14 +++++++------- .../components/GroupEventsScrollTableFilters.vue | 1 - resources/js/components/GroupMapAndList.vue | 2 +- resources/js/components/GroupsTableFilters.vue | 1 - 6 files changed, 9 insertions(+), 13 deletions(-) diff --git a/resources/js/components/AlertBanner.vue b/resources/js/components/AlertBanner.vue index 433336bf90..cff1673221 100644 --- a/resources/js/components/AlertBanner.vue +++ b/resources/js/components/AlertBanner.vue @@ -1,8 +1,7 @@