From 207d0596d049090d0b2f47a33f2e9b074ee6d535 Mon Sep 17 00:00:00 2001 From: gkbishnoi07 Date: Mon, 14 Sep 2026 09:39:26 +0000 Subject: [PATCH] fix(stock-adjustment-draft): report save failures and show description MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit two defects behind 'draft saved but not shown in Previous Draft Records': - submitStockAdjustmentDraft showed 'saved successfully' without checking response.statusCode, so a failed save looked successful and the draft was never persisted. alert the error and stop instead. - the draft list bound adjustment?.draftDescription but the field is draftDesc, so the Description column was always blank. fix the binding. (the empty list itself, when the save truly succeeds, is a backend/no-data matter — the list mapping is correct.) --- .../store-stock-adjustment.component.ts | 10 ++++++++++ .../view-store-stock-adjustment-draft.component.html | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/src/app/app-modules/inventory/store-stock-adjustment/store-stock-adjustment.component.ts b/src/app/app-modules/inventory/store-stock-adjustment/store-stock-adjustment.component.ts index 206d7a6..44d4225 100644 --- a/src/app/app-modules/inventory/store-stock-adjustment/store-stock-adjustment.component.ts +++ b/src/app/app-modules/inventory/store-stock-adjustment/store-stock-adjustment.component.ts @@ -287,6 +287,16 @@ export class StoreStockAdjustmentComponent this.inventoryService .saveStockAdjustmentDraft(temp) .subscribe((response) => { + if (response?.statusCode !== 200) { + // don't report success on a failed save (that made a draft look + // saved while it never landed, so it was missing from the list) + this.confirmationService.alert( + response?.errorMessage || + 'Something went wrong. Please try again.', + 'error', + ); + return; + } if (temp.stockAdjustmentDraftID) { this.confirmationService.alert( this.currentLanguageSet.inventory.updatedSuccessfully, diff --git a/src/app/app-modules/inventory/store-stock-adjustment/view-store-stock-adjustment-draft/view-store-stock-adjustment-draft.component.html b/src/app/app-modules/inventory/store-stock-adjustment/view-store-stock-adjustment-draft/view-store-stock-adjustment-draft.component.html index 9a35664..4b744d8 100644 --- a/src/app/app-modules/inventory/store-stock-adjustment/view-store-stock-adjustment-draft/view-store-stock-adjustment-draft.component.html +++ b/src/app/app-modules/inventory/store-stock-adjustment/view-store-stock-adjustment-draft/view-store-stock-adjustment-draft.component.html @@ -110,7 +110,7 @@ {{ i + 1 }} {{ adjustment?.stockAdjustmentDraftID }} {{ adjustment?.refNo }} - {{ adjustment?.draftDescription }} + {{ adjustment?.draftDesc }} {{ adjustment?.createdBy }} {{ adjustment?.createdDate | istDate: "dd/MM/yyyy" }}