From 23c585e5dd566a312e7698d20daed96cbd68214c Mon Sep 17 00:00:00 2001 From: Spencer Bryngelson Date: Thu, 17 Sep 2026 11:42:37 -0400 Subject: [PATCH] Fix the grcbc outflow tests that #1854 broke #1877 added TestGrcbcOutflowTargets with grcbc_in = T in its fixture but never supplied the inflow state. #1854, merged next, correctly began requiring that state, so master has failed Lint Toolchain / Toolchain Compatibility on every push and every open PR since 386e615. grcbc_in and grcbc_out are independent switches, and these tests exercise only the outflow branch, so the fix is to leave grcbc_in off. A -7 boundary without grcbc_in is a plain subsonic inflow, which is all the far side of the fixture needs. Neither validator changes. Diagnosed and fixed with Claude Code. --- toolchain/mfc/test_case_validator.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/toolchain/mfc/test_case_validator.py b/toolchain/mfc/test_case_validator.py index 253a510e1..2c9ae0751 100644 --- a/toolchain/mfc/test_case_validator.py +++ b/toolchain/mfc/test_case_validator.py @@ -541,7 +541,10 @@ class TestGrcbcOutflowTargets(ConstraintTestCase): nothing naming the BC. """ - OUT = {"bc_x%beg": -7, "bc_x%end": -8, "bc_x%grcbc_in": "T", "bc_x%grcbc_out": "T"} + # grcbc_in is deliberately off: it is an independent switch that now demands the full inflow state + # (#1854), and these tests exercise the outflow branch alone. A -7 boundary without grcbc_in is a + # plain subsonic inflow, which is all the fixture needs on the far side. + OUT = {"bc_x%beg": -7, "bc_x%end": -8, "bc_x%grcbc_out": "T"} def test_grcbc_out_requires_pres_out(self): self.assertRejects({**BASE_2D, **self.OUT}, "bc_x%pres_out must be specified") @@ -563,6 +566,6 @@ def test_transverse_components_are_not_required(self): def test_the_required_component_follows_the_direction(self): """dir_idx(1) is 2 at a y boundary, so it is vel_out(2) that must be given, not vel_out(1).""" - y = {**BASE_2D, "bc_y%beg": -7, "bc_y%end": -8, "bc_y%grcbc_in": "T", "bc_y%grcbc_out": "T", "bc_y%pres_out": 1.0, "bc_y%grcbc_vel_out": "T"} + y = {**BASE_2D, "bc_y%beg": -7, "bc_y%end": -8, "bc_y%grcbc_out": "T", "bc_y%pres_out": 1.0, "bc_y%grcbc_vel_out": "T"} self.assertRejects(y, "bc_y%vel_out(2) must be specified") self.assertAccepts({**y, "bc_y%vel_out(2)": 0.0})