From b829835194d19d758bcbb0a7bbe815bb2f6ffcfb Mon Sep 17 00:00:00 2001
From: Chris Huber <chubes@chubes.net>
Date: Mon, 26 Oct 2026 09:30:08 -0400
Subject: [PATCH] Remove dead Markdown Database Integration persistence
 policies

CanonicalPersistencePolicy declared partition identities through markdown_db_table_persistence_policy and LogPersistencePolicy bounded Action Scheduler log snapshots through markdown_db_persistent_table_query. MDI no longer applies either filter: the write engine and SQLite mirror that read them are retired, and mdi-native folds legacy partitions into snapshots.
---
 .../ActionScheduler/LogPersistencePolicy.php  |  80 -------------
 .../Bootstrap/AlwaysOnServiceProvider.php     |   5 +-
 .../Database/CanonicalPersistencePolicy.php   |  44 -------
 ...scheduler-log-persistence-policy-smoke.php | 110 ------------------
 tests/canonical-persistence-policy-smoke.php  |  40 -------
 5 files changed, 1 insertion(+), 278 deletions(-)
 delete mode 100644 inc/Core/ActionScheduler/LogPersistencePolicy.php
 delete mode 100644 inc/Core/Database/CanonicalPersistencePolicy.php
 delete mode 100644 tests/action-scheduler-log-persistence-policy-smoke.php
 delete mode 100644 tests/canonical-persistence-policy-smoke.php

diff --git a/inc/Core/ActionScheduler/LogPersistencePolicy.php b/inc/Core/ActionScheduler/LogPersistencePolicy.php
deleted file mode 100644
index a500292852..0000000000
--- a/inc/Core/ActionScheduler/LogPersistencePolicy.php
+++ /dev/null
@@ -1,80 +0,0 @@
-<?php
-/**
- * Action Scheduler log persistence policy for file-backed database runtimes.
- *
- * @package DataMachine\Core\ActionScheduler
- */
-
-namespace DataMachine\Core\ActionScheduler;
-
-defined( 'ABSPATH' ) || exit;
-
-/**
- * Bounds the Action Scheduler log snapshot without changing its live table.
- */
-class LogPersistencePolicy {
-
-	public const DEFAULT_ROW_BUDGET = 10000;
-
-	private const MAXIMUM_ROW_BUDGET = 100000;
-	private const TABLE_SUFFIX       = 'actionscheduler_logs';
-
-	/**
-	 * Register the optional Markdown Database Integration query policy.
-	 *
-	 * Registering a WordPress filter is inert unless an integration applies it.
-	 */
-	public static function register(): void {
-		if ( ! function_exists( 'add_filter' ) ) {
-			return;
-		}
-
-		add_filter( 'markdown_db_persistent_table_query', array( self::class, 'filterPersistentTableQuery' ), 100, 4 );
-	}
-
-	/**
-	 * Retain a deterministic recent log window in chronological output order.
-	 *
-	 * The supplied query already owns table quoting and prefix handling. Wrapping
-	 * it also preserves predicates or projections added by earlier policy owners.
-	 *
-	 * @param mixed      $query        Persistence query supplied by Markdown Database Integration.
-	 * @param string     $table_suffix Table name without the WordPress prefix.
-	 * @param string     $table        Full table name.
-	 * @param array|bool|null $policy  Persistence policy, if configured.
-	 * @return mixed
-	 */
-	// phpcs:ignore Generic.CodeAnalysis.UnusedFunctionParameter.FoundAfterLastUsed -- The filter contract supplies four arguments to this callback.
-	public static function filterPersistentTableQuery( $query, string $table_suffix, string $table, $policy ) {
-		if ( self::TABLE_SUFFIX !== $table_suffix || ! is_string( $query ) || '' === $query ) {
-			return $query;
-		}
-
-		$budget = self::rowBudget();
-
-		return sprintf(
-			'SELECT * FROM ( SELECT * FROM ( %s ) AS datamachine_action_scheduler_log_source ORDER BY log_date_gmt DESC, log_id DESC LIMIT %d ) AS datamachine_action_scheduler_log_window ORDER BY log_date_gmt ASC, log_id ASC',
-			$query,
-			$budget
-		);
-	}
-
-	/**
-	 * Get the validated maximum number of rows retained in a log snapshot.
-	 */
-	public static function rowBudget(): int {
-		$budget = function_exists( 'apply_filters' )
-			? apply_filters( 'datamachine_action_scheduler_log_persistence_row_budget', self::DEFAULT_ROW_BUDGET )
-			: self::DEFAULT_ROW_BUDGET;
-
-		if ( is_int( $budget ) ) {
-			return min( self::MAXIMUM_ROW_BUDGET, max( 1, $budget ) );
-		}
-
-		if ( is_string( $budget ) && 1 === preg_match( '/\A\d+\z/D', $budget ) ) {
-			return min( self::MAXIMUM_ROW_BUDGET, max( 1, (int) $budget ) );
-		}
-
-		return self::DEFAULT_ROW_BUDGET;
-	}
-}
diff --git a/inc/Core/Bootstrap/AlwaysOnServiceProvider.php b/inc/Core/Bootstrap/AlwaysOnServiceProvider.php
index 1dcc0aa066..e0e4d94e3c 100644
--- a/inc/Core/Bootstrap/AlwaysOnServiceProvider.php
+++ b/inc/Core/Bootstrap/AlwaysOnServiceProvider.php
@@ -15,7 +15,7 @@
 final class AlwaysOnServiceProvider {
 
 	/**
-	 * Register Action Scheduler policies and lightweight WordPress hooks.
+	 * Load Action Scheduler and register lightweight WordPress hooks.
 	 */
 	public static function register_scheduler(): void {
 		$plugin_root = dirname( __DIR__, 3 );
@@ -24,9 +24,6 @@ public static function register_scheduler(): void {
 			require_once $plugin_root . '/vendor/woocommerce/action-scheduler/action-scheduler.php';
 		}
 
-		\DataMachine\Core\ActionScheduler\LogPersistencePolicy::register();
-		\DataMachine\Core\Database\CanonicalPersistencePolicy::register();
-
 		add_action(
 			'action_scheduler_init',
 			array( \DataMachine\Core\ActionScheduler\GroupRegistrar::class, 'ensureDataMachineGroup' ),
diff --git a/inc/Core/Database/CanonicalPersistencePolicy.php b/inc/Core/Database/CanonicalPersistencePolicy.php
deleted file mode 100644
index fc3ccce0cd..0000000000
--- a/inc/Core/Database/CanonicalPersistencePolicy.php
+++ /dev/null
@@ -1,44 +0,0 @@
-<?php
-/**
- * Canonical persistence policy for high-churn Data Machine tables.
- *
- * @package DataMachine\Core\Database
- */
-
-namespace DataMachine\Core\Database;
-
-defined( 'ABSPATH' ) || exit;
-
-class CanonicalPersistencePolicy {
-
-	/** Register optional policy consumed by file-backed database runtimes. */
-	public static function register(): void {
-		if ( function_exists( 'add_filter' ) ) {
-			add_filter( 'markdown_db_table_persistence_policy', array( self::class, 'filterTablePolicy' ) );
-		}
-	}
-
-	/**
-	 * Declare stable row identities without replacing policies owned elsewhere.
-	 *
-	 * @param mixed $policy Existing table policy map.
-	 * @return array<string,mixed>
-	 */
-	public static function filterTablePolicy( $policy ): array {
-		$policy = is_array( $policy ) ? $policy : array();
-		self::addDefaultIdentity( $policy, 'datamachine_jobs', 'job_id' );
-		self::addDefaultIdentity( $policy, 'datamachine_logs', 'id' );
-		return $policy;
-	}
-
-	/** @param array<string,mixed> $policy */
-	private static function addDefaultIdentity( array &$policy, string $table, string $column ): void {
-		if ( ! array_key_exists( $table, $policy ) ) {
-			$policy[ $table ] = array( 'partition_by' => $column );
-			return;
-		}
-		if ( is_array( $policy[ $table ] ) && ! array_key_exists( 'partition_by', $policy[ $table ] ) ) {
-			$policy[ $table ]['partition_by'] = $column;
-		}
-	}
-}
diff --git a/tests/action-scheduler-log-persistence-policy-smoke.php b/tests/action-scheduler-log-persistence-policy-smoke.php
deleted file mode 100644
index 2a53dfe0f4..0000000000
--- a/tests/action-scheduler-log-persistence-policy-smoke.php
+++ /dev/null
@@ -1,110 +0,0 @@
-<?php
-/**
- * Smoke coverage for bounded Action Scheduler log persistence (#3095).
- *
- * Run with: php tests/action-scheduler-log-persistence-policy-smoke.php
- *
- * @package DataMachine\Tests
- */
-
-declare( strict_types=1 );
-
-if ( ! defined( 'ABSPATH' ) ) {
-	define( 'ABSPATH', dirname( __DIR__ ) . '/' );
-}
-
-$filters = array();
-
-if ( ! function_exists( 'add_filter' ) ) {
-	function add_filter( string $hook, callable $callback, int $priority = 10, int $accepted_args = 1 ): void {
-		global $filters;
-		$filters[ $hook ][ $priority ][] = array( $callback, $accepted_args );
-	}
-}
-
-if ( ! function_exists( 'apply_filters' ) ) {
-	function apply_filters( string $hook, $value, ...$args ) {
-		global $filters;
-		if ( empty( $filters[ $hook ] ) ) {
-			return $value;
-		}
-
-		ksort( $filters[ $hook ] );
-		foreach ( $filters[ $hook ] as $callbacks ) {
-			foreach ( $callbacks as $registered_callback ) {
-				list( $callback, $accepted_args ) = $registered_callback;
-				$value = $callback( $value, ...array_slice( $args, 0, $accepted_args - 1 ) );
-			}
-		}
-
-		return $value;
-	}
-}
-
-require_once dirname( __DIR__ ) . '/inc/Core/ActionScheduler/LogPersistencePolicy.php';
-
-use DataMachine\Core\ActionScheduler\LogPersistencePolicy;
-
-$failed = 0;
-$total  = 0;
-
-function assert_log_persistence( string $name, bool $condition, string $detail = '' ): void {
-	global $failed, $total;
-	++$total;
-	if ( $condition ) {
-		echo "  [PASS] {$name}\n";
-		return;
-	}
-
-	++$failed;
-	echo "  [FAIL] {$name}" . ( '' !== $detail ? ": {$detail}" : '' ) . "\n";
-}
-
-echo "=== action-scheduler-log-persistence-policy-smoke ===\n";
-
-LogPersistencePolicy::register();
-
-$source_query = 'SELECT * FROM `tenant_42_actionscheduler_logs` ORDER BY 1';
-$unchanged    = apply_filters( 'markdown_db_persistent_table_query', $source_query, 'posts', 'tenant_42_posts', null );
-assert_log_persistence( 'unrelated tables retain their supplied query', $source_query === $unchanged );
-
-$bounded = apply_filters( 'markdown_db_persistent_table_query', $source_query, 'actionscheduler_logs', 'tenant_42_actionscheduler_logs', null );
-assert_log_persistence(
-	'custom-prefix log table is bounded through the supplied query',
-	str_contains( $bounded, $source_query ) && str_contains( $bounded, 'LIMIT 10000' )
-);
-assert_log_persistence(
-	'recent window and emitted snapshot have deterministic inverse ordering',
-	str_contains( $bounded, 'ORDER BY log_date_gmt DESC, log_id DESC LIMIT 10000' )
-		&& str_ends_with( $bounded, 'ORDER BY log_date_gmt ASC, log_id ASC' )
-);
-
-add_filter(
-	'markdown_db_persistent_table_query',
-	static fn( string $query ): string => $query . ' /* third-party-policy */',
-	20
-);
-$composed = apply_filters( 'markdown_db_persistent_table_query', $source_query, 'actionscheduler_logs', 'custom_actionscheduler_logs', null );
-assert_log_persistence(
-	'earlier third-party query policies are preserved inside the bounded source',
-	str_contains( $composed, '/* third-party-policy */ ) AS datamachine_action_scheduler_log_source' )
-);
-
-add_filter( 'datamachine_action_scheduler_log_persistence_row_budget', static fn() => '25', 10 );
-assert_log_persistence( 'digit-string budget is accepted', 25 === LogPersistencePolicy::rowBudget() );
-add_filter( 'datamachine_action_scheduler_log_persistence_row_budget', static fn() => '25; DROP TABLE posts', 20 );
-assert_log_persistence( 'unsafe budget falls back to the safe default', 10000 === LogPersistencePolicy::rowBudget() );
-$unsafe_budget_query = LogPersistencePolicy::filterPersistentTableQuery( $source_query, 'actionscheduler_logs', 'tenant_42_actionscheduler_logs', null );
-assert_log_persistence(
-	'unsafe budget is never interpolated into SQL',
-	str_contains( $unsafe_budget_query, 'LIMIT 10000' ) && ! str_contains( $unsafe_budget_query, 'DROP TABLE' )
-);
-add_filter( 'datamachine_action_scheduler_log_persistence_row_budget', static fn() => 999999, 30 );
-assert_log_persistence( 'budget has a bounded maximum', 100000 === LogPersistencePolicy::rowBudget() );
-
-if ( $failed > 0 ) {
-	echo "\naction-scheduler-log-persistence-policy-smoke failed: {$failed}/{$total} assertions failed.\n";
-	exit( 1 );
-}
-
-echo "\naction-scheduler-log-persistence-policy-smoke passed: {$total} assertions.\n";
diff --git a/tests/canonical-persistence-policy-smoke.php b/tests/canonical-persistence-policy-smoke.php
deleted file mode 100644
index 4e9977668b..0000000000
--- a/tests/canonical-persistence-policy-smoke.php
+++ /dev/null
@@ -1,40 +0,0 @@
-<?php
-/** Data Machine canonical persistence policy coverage. */
-
-declare( strict_types=1 );
-
-define( 'ABSPATH', __DIR__ . '/' );
-$GLOBALS['dm_policy_filters'] = array();
-
-function add_filter( string $tag, callable $callback ): void { $GLOBALS['dm_policy_filters'][ $tag ][] = $callback; }
-function apply_filters( string $tag, mixed $value ): mixed { foreach ( $GLOBALS['dm_policy_filters'][ $tag ] ?? array() as $callback ) { $value = $callback( $value ); } return $value; }
-
-require_once dirname( __DIR__ ) . '/inc/Core/Database/CanonicalPersistencePolicy.php';
-
-use DataMachine\Core\Database\CanonicalPersistencePolicy;
-
-CanonicalPersistencePolicy::register();
-$policy = apply_filters(
-	'markdown_db_table_persistence_policy',
-	array(
-		'other_table'      => false,
-		'datamachine_jobs' => array( 'custom' => 'preserved' ),
-		'datamachine_logs' => false,
-	)
-);
-$overrides = CanonicalPersistencePolicy::filterTablePolicy(
-	array(
-		'datamachine_jobs' => false,
-		'datamachine_logs' => array( 'partition_by' => 'external_id' ),
-	)
-);
-
-$passed = false === $policy['other_table']
-	&& 'preserved' === $policy['datamachine_jobs']['custom']
-	&& 'job_id' === $policy['datamachine_jobs']['partition_by']
-	&& false === $policy['datamachine_logs']
-	&& false === $overrides['datamachine_jobs']
-	&& 'external_id' === $overrides['datamachine_logs']['partition_by'];
-
-echo ( $passed ? 'PASS' : 'FAIL' ) . ': high-churn tables declare stable partition identities without replacing existing policy.' . PHP_EOL;
-exit( $passed ? 0 : 1 );