Skip to content

Commit 7366ffe

Browse files
Disable unittest and selenium (#873)
1 parent afc1c5f commit 7366ffe

3 files changed

Lines changed: 22 additions & 7 deletions

File tree

‎Dockerfile‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,12 @@ RUN rm -rf \
4242

4343
# CI Visibility paths/integrations
4444
RUN rm -rf \
45-
./python/lib/$runtime/site-packages/ddtrace/contrib/coverage/ \
46-
./python/lib/$runtime/site-packages/ddtrace/contrib/pytest/ \
47-
./python/lib/$runtime/site-packages/ddtrace/contrib/pytest_bdd/ \
48-
./python/lib/$runtime/site-packages/ddtrace/contrib/pytest_benchmark/ \
49-
./python/lib/$runtime/site-packages/ddtrace/contrib/selenium/ \
50-
./python/lib/$runtime/site-packages/ddtrace/contrib/unittest/ \
45+
./python/lib/$runtime/site-packages/ddtrace/contrib/internal/coverage/ \
46+
./python/lib/$runtime/site-packages/ddtrace/contrib/internal/pytest/ \
47+
./python/lib/$runtime/site-packages/ddtrace/contrib/internal/pytest_bdd/ \
48+
./python/lib/$runtime/site-packages/ddtrace/contrib/internal/pytest_benchmark/ \
49+
./python/lib/$runtime/site-packages/ddtrace/contrib/internal/selenium/ \
50+
./python/lib/$runtime/site-packages/ddtrace/contrib/internal/unittest/ \
5151
./python/lib/$runtime/site-packages/ddtrace/ext/ci_visibility \
5252
./python/lib/$runtime/site-packages/ddtrace/ext/test_visibility \
5353
./python/lib/$runtime/site-packages/ddtrace/internal/ci_visibility \

‎datadog_lambda/patch.py‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,10 @@ def patch_all():
3030
_patch_for_integration_tests()
3131

3232
if config.trace_enabled:
33-
patch_all_dd()
33+
# unittest and selenium are CI Visibility integrations. The layer strips
34+
# their code and ddtrace.internal.ci_visibility, so leaving them enabled
35+
# logs an import error whenever the user's code imports those modules.
36+
patch_all_dd(unittest=False, selenium=False)
3437
else:
3538
_patch_http()
3639
_ensure_patch_requests()

‎tests/test_patch.py‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,3 +94,15 @@ def test_patch_requests_with_headers_none(self):
9494
self.assertEqual(r.request.headers[TraceHeader.TRACE_ID], "123")
9595
self.assertEqual(r.request.headers[TraceHeader.PARENT_ID], "321")
9696
self.assertEqual(r.request.headers[TraceHeader.SAMPLING_PRIORITY], "2")
97+
98+
99+
@patch("datadog_lambda.patch.patch_all_dd")
100+
@patch("datadog_lambda.patch.config")
101+
def test_patch_all_disables_ci_visibility_integrations(mock_config, mock_patch_all_dd):
102+
from datadog_lambda.patch import patch_all
103+
104+
mock_config.trace_enabled = True
105+
mock_config.integration_test = False
106+
patch_all()
107+
108+
mock_patch_all_dd.assert_called_once_with(unittest=False, selenium=False)

0 commit comments

Comments
 (0)